Skip to content

[NOT FOR MERGING] upgrade packages #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 18 commits into
base: dotnet10/UpdateToPreview
Choose a base branch
from
Draft

[NOT FOR MERGING] upgrade packages #7319

wants to merge 18 commits into from

Conversation

NachoEchevarria
Copy link
Contributor

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@dd-trace-dotnet-ci-bot
Copy link

dd-trace-dotnet-ci-bot bot commented Aug 1, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (73ms)  : 71, 74
     .   : milestone, 73,

    section Baseline
    This PR (7319) - mean (69ms)  : 64, 74
     .   : milestone, 69,
    master - mean (70ms)  : 66, 73
     .   : milestone, 70,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (1,028ms)  : 1001, 1054
     .   : milestone, 1028,
    master - mean (1,034ms)  : 1011, 1058
     .   : milestone, 1034,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (107ms)  : 106, 107
     .   : milestone, 107,
    master - mean (109ms)  : 107, 111
     .   : milestone, 109,

    section Baseline
    This PR (7319) - mean (105ms)  : 103, 108
     .   : milestone, 105,
    master - mean (107ms)  : 105, 110
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (722ms)  : 711, 733
     .   : milestone, 722,
    master - mean (735ms)  : 721, 748
     .   : milestone, 735,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (97ms)  : 95, 98
     .   : milestone, 97,

    section Baseline
    This PR (7319) - mean (93ms)  : 91, 95
     .   : milestone, 93,
    master - mean (95ms)  : 93, 98
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (674ms)  : 666, 683
     .   : milestone, 674,
    master - mean (695ms)  : 677, 713
     .   : milestone, 695,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (93ms)  : 92, 94
     .   : milestone, 93,
    master - mean (95ms)  : 94, 97
     .   : milestone, 95,

    section Baseline
    This PR (7319) - mean (92ms)  : 91, 94
     .   : milestone, 92,
    master - mean (95ms)  : 91, 99
     .   : milestone, 95,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (619ms)  : 610, 627
     .   : milestone, 619,
    master - mean (630ms)  : 617, 644
     .   : milestone, 630,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (195ms)  : 192, 198
     .   : milestone, 195,
    master - mean (195ms)  : 192, 197
     .   : milestone, 195,

    section Baseline
    This PR (7319) - mean (194ms)  : 185, 204
     .   : milestone, 194,
    master - mean (191ms)  : 187, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (1,152ms)  : 1110, 1193
     .   : milestone, 1152,
    master - mean (1,140ms)  : 1115, 1165
     .   : milestone, 1140,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (278ms)  : 272, 284
     .   : milestone, 278,
    master - mean (276ms)  : 272, 279
     .   : milestone, 276,

    section Baseline
    This PR (7319) - mean (275ms)  : 270, 280
     .   : milestone, 275,
    master - mean (275ms)  : 271, 279
     .   : milestone, 275,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (915ms)  : 885, 946
     .   : milestone, 915,
    master - mean (915ms)  : 895, 935
     .   : milestone, 915,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (268ms)  : 264, 273
     .   : milestone, 268,
    master - mean (269ms)  : 266, 272
     .   : milestone, 269,

    section Baseline
    This PR (7319) - mean (269ms)  : 264, 274
     .   : milestone, 269,
    master - mean (269ms)  : 265, 272
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (902ms)  : 873, 932
     .   : milestone, 902,
    master - mean (906ms)  : 877, 935
     .   : milestone, 906,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7319) - mean (267ms)  : 264, 271
     .   : milestone, 267,
    master - mean (267ms)  : 263, 271
     .   : milestone, 267,

    section Baseline
    This PR (7319) - mean (269ms)  : 262, 276
     .   : milestone, 269,
    master - mean (266ms)  : 262, 271
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (7319) - mean (814ms)  : 792, 836
     .   : milestone, 814,
    master - mean (820ms)  : 797, 843
     .   : milestone, 820,
Loading

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Aug 1, 2025 •
edited by datadog-official bot
Loading

⚠️ Tests

⚠️ Warnings

🧪 5 Tests failed

SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqliteTests (Datadog) 
Expected exit code: 0, actual exit code: 139.
SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqliteTests (Datadog) 
Expected exit code: 0, actual exit code: 139.
SubmitsTraces from Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqliteTests (Datadog) 
Expected exit code: 0, actual exit code: 139.
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 12452b6 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Aug 8, 2025 •
edited
Loading

Benchmarks

Benchmarks Report for benchmark platform 🐌

Benchmarks for #7319 compared to master:

  • 5 benchmarks are slower, with geometric mean 1.355
  • 5 benchmarks have fewer allocations
  • 7 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #7319

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑net472 6.07 KB 6.03 KB -48 B -0.79%
Benchmarks.Trace.ActivityBenchmark.StartStopWithChild‑netcoreapp3.1 5.71 KB 5.66 KB -59 B -1.03%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 10.6μs 55.2ns 247ns 0 0 0 5.48 KB
master StartStopWithChild netcoreapp3.1 13.8μs 65ns 260ns 0 0 0 5.71 KB
master StartStopWithChild net472 22.3μs 118ns 581ns 0.912 0.228 0 6.07 KB
#7319 StartStopWithChild net6.0 10.4μs 56.9ns 337ns 0 0 0 5.51 KB
#7319 StartStopWithChild netcoreapp3.1 14.1μs 71ns 325ns 0 0 0 5.66 KB
#7319 StartStopWithChild net472 21.9μs 116ns 594ns 0.858 0.214 0 6.03 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 934μs 119ns 446ns 0 0 0 2.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 1.01ms 266ns 995ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 1.2ms 127ns 494ns 0 0 0 3.31 KB
#7319 WriteAndFlushEnrichedTraces net6.0 931μs 102ns 395ns 0 0 0 2.71 KB
#7319 WriteAndFlushEnrichedTraces netcoreapp3.1 1.04ms 4.08μs 15.8μs 0 0 0 2.7 KB
#7319 WriteAndFlushEnrichedTraces net472 1.2ms 51ns 191ns 0 0 0 3.31 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 327μs 1.34μs 5.21μs 0 0 0 179.42 KB
master AllCycleSimpleBody netcoreapp3.1 467μs 1.81μs 7.03μs 0 0 0 183.24 KB
master AllCycleSimpleBody net472 422μs 51.5ns 193ns 33.3 2.08 0 209.98 KB
master AllCycleMoreComplexBody net6.0 336μs 199ns 769ns 0 0 0 182.92 KB
master AllCycleMoreComplexBody netcoreapp3.1 501μs 146ns 566ns 0 0 0 186.66 KB
master AllCycleMoreComplexBody net472 432μs 147ns 569ns 32.3 0 0 213.49 KB
master ObjectExtractorSimpleBody net6.0 316ns 0.0829ns 0.321ns 0 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 396ns 1.92ns 7.92ns 0 0 0 272 B
master ObjectExtractorSimpleBody net472 295ns 0.0266ns 0.0957ns 0.0445 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 6.34μs 31.7ns 134ns 0 0 0 3.78 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 7.76μs 35.6ns 142ns 0 0 0 3.69 KB
master ObjectExtractorMoreComplexBody net472 6.69μs 7.03ns 27.2ns 0.601 0 0 3.8 KB
#7319 AllCycleSimpleBody net6.0 332μs 360ns 1.35μs 0 0 0 179.42 KB
#7319 AllCycleSimpleBody netcoreapp3.1 488μs 916ns 3.55μs 0 0 0 183.24 KB
#7319 AllCycleSimpleBody net472 424μs 80.1ns 300ns 33.3 2.08 0 209.98 KB
#7319 AllCycleMoreComplexBody net6.0 337μs 372ns 1.34μs 0 0 0 182.93 KB
#7319 AllCycleMoreComplexBody netcoreapp3.1 475μs 1.83μs 7.08μs 0 0 0 186.66 KB
#7319 AllCycleMoreComplexBody net472 432μs 154ns 598ns 32.3 0 0 213.49 KB
#7319 ObjectExtractorSimpleBody net6.0 310ns 1.7ns 10.5ns 0 0 0 280 B
#7319 ObjectExtractorSimpleBody netcoreapp3.1 405ns 0.612ns 2.37ns 0 0 0 272 B
#7319 ObjectExtractorSimpleBody net472 301ns 0.0335ns 0.126ns 0.044 0 0 281 B
#7319 ObjectExtractorMoreComplexBody net6.0 6.31μs 16.2ns 62.9ns 0 0 0 3.78 KB
#7319 ObjectExtractorMoreComplexBody netcoreapp3.1 7.85μs 39.3ns 167ns 0 0 0 3.69 KB
#7319 ObjectExtractorMoreComplexBody net472 6.74μs 0.903ns 3.38ns 0.573 0 0 3.8 KB
Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EncodeArgs net6.0 76.7μs 266ns 1.03μs 0 0 0 32.4 KB
master EncodeArgs netcoreapp3.1 97.1μs 218ns 815ns 0 0 0 32.4 KB
master EncodeArgs net472 110μs 7.63ns 29.6ns 4.94 0 0 32.51 KB
master EncodeLegacyArgs net6.0 143μs 19.9ns 71.7ns 0 0 0 2.14 KB
master EncodeLegacyArgs netcoreapp3.1 211μs 57.9ns 209ns 0 0 0 2.14 KB
master EncodeLegacyArgs net472 261μs 59.8ns 224ns 0 0 0 2.16 KB
#7319 EncodeArgs net6.0 76.9μs 63.2ns 236ns 0 0 0 32.4 KB
#7319 EncodeArgs netcoreapp3.1 97.7μs 195ns 756ns 0 0 0 32.4 KB
#7319 EncodeArgs net472 110μs 13.1ns 50.7ns 4.93 0 0 32.51 KB
#7319 EncodeLegacyArgs net6.0 146μs 72.8ns 282ns 0 0 0 2.15 KB
#7319 EncodeLegacyArgs netcoreapp3.1 199μs 45ns 174ns 0 0 0 2.14 KB
#7319 EncodeLegacyArgs net472 266μs 147ns 568ns 0 0 0 2.16 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7319

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack‑netcoreapp3.1 2.374 305,980.70 726,260.16

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWafRealisticBenchmark net6.0 402μs 65ns 235ns 0 0 0 4.55 KB
master RunWafRealisticBenchmark netcoreapp3.1 414μs 101ns 379ns 0 0 0 4.48 KB
master RunWafRealisticBenchmark net472 436μs 54.3ns 203ns 0 0 0 4.66 KB
master RunWafRealisticBenchmarkWithAttack net6.0 288μs 58.7ns 220ns 0 0 0 2.24 KB
master RunWafRealisticBenchmarkWithAttack netcoreapp3.1 306μs 204ns 708ns 0 0 0 2.22 KB
master RunWafRealisticBenchmarkWithAttack net472 318μs 22.5ns 87.2ns 0 0 0 2.29 KB
#7319 RunWafRealisticBenchmark net6.0 399μs 83.6ns 324ns 0 0 0 4.55 KB
#7319 RunWafRealisticBenchmark netcoreapp3.1 419μs 108ns 418ns 0 0 0 4.48 KB
#7319 RunWafRealisticBenchmark net472 431μs 132ns 510ns 0 0 0 4.66 KB
#7319 RunWafRealisticBenchmarkWithAttack net6.0 296μs 110ns 424ns 0 0 0 2.24 KB
#7319 RunWafRealisticBenchmarkWithAttack netcoreapp3.1 724μs 3.59μs 14.8μs 0 0 0 2.22 KB
#7319 RunWafRealisticBenchmarkWithAttack net472 316μs 35ns 126ns 0 0 0 2.29 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 61.1μs 36.4ns 141ns 0 0 0 14.52 KB
master SendRequest netcoreapp3.1 71.5μs 338ns 1.31μs 0 0 0 17.42 KB
master SendRequest net472 0.007ns 0.00152ns 0.00588ns 0 0 0 0 b
#7319 SendRequest net6.0 61.4μs 29.6ns 111ns 0 0 0 14.52 KB
#7319 SendRequest netcoreapp3.1 70.3μs 148ns 552ns 0 0 0 17.42 KB
#7319 SendRequest net472 0.0128ns 0.00168ns 0.00605ns 0 0 0 0 b
Benchmarks.Trace.CharSliceBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7319

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 1.133 798,677.60 904,700.45

More allocations ⚠️ in #7319

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑netcoreapp3.1 0 b 1 B 1 B ∞
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net6.0 2 B 4 B 2 B 100.00%

Fewer allocations 🎉 in #7319

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net6.0 4 B 1 B -3 B -75.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice‑net472 73 B 0 b -73 B -100.00%
Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSliceWithPool‑net472 47 B 0 b -47 B -100.00%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master OriginalCharSlice net6.0 1.9ms 4.21μs 16.3μs 0 0 0 640.01 KB
master OriginalCharSlice netcoreapp3.1 2.05ms 6.28μs 23.5μs 0 0 0 640 KB
master OriginalCharSlice net472 2.66ms 235ns 911ns 100 0 0 641.95 KB
master OptimizedCharSlice net6.0 1.41ms 94.1ns 364ns 0 0 0 2 B
master OptimizedCharSlice netcoreapp3.1 1.85ms 116ns 447ns 0 0 0 1 B
master OptimizedCharSlice net472 1.96ms 155ns 599ns 0 0 0 73 B
master OptimizedCharSliceWithPool net6.0 810μs 53ns 198ns 0 0 0 4 B
master OptimizedCharSliceWithPool netcoreapp3.1 799μs 50.8ns 197ns 0 0 0 0 b
master OptimizedCharSliceWithPool net472 1.15ms 58ns 225ns 0 0 0 47 B
#7319 OriginalCharSlice net6.0 1.89ms 4.28μs 16.6μs 0 0 0 640.01 KB
#7319 OriginalCharSlice netcoreapp3.1 2.1ms 9.9μs 35.7μs 0 0 0 640 KB
#7319 OriginalCharSlice net472 2.66ms 2.29μs 8.87μs 100 0 0 641.95 KB
#7319 OptimizedCharSlice net6.0 1.48ms 546ns 2.12μs 0 0 0 4 B
#7319 OptimizedCharSlice netcoreapp3.1 1.69ms 99.8ns 373ns 0 0 0 1 B
#7319 OptimizedCharSlice net472 1.99ms 461ns 1.78μs 0 0 0 0 b
#7319 OptimizedCharSliceWithPool net6.0 809μs 38ns 142ns 0 0 0 1 B
#7319 OptimizedCharSliceWithPool netcoreapp3.1 905μs 50.8ns 197ns 0 0 0 1 B
#7319 OptimizedCharSliceWithPool net472 1.14ms 66.9ns 259ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #7319

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 1.188 670,786.61 796,833.75 several?

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 729μs 2.03μs 7.87μs 0 0 0 41.72 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 690μs 4μs 34.6μs 0 0 0 41.88 KB
master WriteAndFlushEnrichedTraces net472 851μs 2.04μs 7.64μs 8.33 0 0 56.42 KB
#7319 WriteAndFlushEnrichedTraces net6.0 668μs 897ns 3.47μs 0 0 0 41.68 KB
#7319 WriteAndFlushEnrichedTraces netcoreapp3.1 798μs 2.31μs 8.93μs 0 0 0 41.86 KB
#7319 WriteAndFlushEnrichedTraces net472 896μs 4.09μs 15.8μs 8.33 0 0 56.39 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 2.01μs 1.99ns 7.72ns 0 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 2.55μs 11.4ns 44.2ns 0 0 0 1.02 KB
master ExecuteNonQuery net472 2.72μs 4.81ns 18.6ns 0.148 0.0135 0 987 B
#7319 ExecuteNonQuery net6.0 1.91μs 9.66ns 43.2ns 0 0 0 1.02 KB
#7319 ExecuteNonQuery netcoreapp3.1 2.54μs 9.8ns 37.9ns 0 0 0 1.02 KB
#7319 ExecuteNonQuery net472 2.92μs 3.44ns 13.3ns 0.145 0.0145 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.74μs 9.29ns 47.3ns 0 0 0 1.03 KB
master CallElasticsearch netcoreapp3.1 2.24μs 9.64ns 37.3ns 0 0 0 1.03 KB
master CallElasticsearch net472 3.59μs 2.35ns 9.08ns 0.162 0 0 1.04 KB
master CallElasticsearchAsync net6.0 1.78μs 9.2ns 41.1ns 0 0 0 1.01 KB
master CallElasticsearchAsync netcoreapp3.1 2.46μs 8.26ns 32ns 0 0 0 1.08 KB
master CallElasticsearchAsync net472 3.74μs 3.51ns 13.6ns 0.169 0 0 1.1 KB
#7319 CallElasticsearch net6.0 1.7μs 7.3ns 26.3ns 0 0 0 1.03 KB
#7319 CallElasticsearch netcoreapp3.1 2.25μs 0.955ns 3.7ns 0 0 0 1.03 KB
#7319 CallElasticsearch net472 3.48μs 2.08ns 8.05ns 0.156 0 0 1.04 KB
#7319 CallElasticsearchAsync net6.0 1.78μs 9.1ns 44.6ns 0 0 0 1.01 KB
#7319 CallElasticsearchAsync netcoreapp3.1 2.43μs 10.1ns 39ns 0 0 0 1.08 KB
#7319 CallElasticsearchAsync net472 3.65μs 1.9ns 7.35ns 0.165 0 0 1.1 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.76μs 8.54ns 35.2ns 0 0 0 952 B
master ExecuteAsync netcoreapp3.1 2.28μs 11.2ns 49ns 0 0 0 952 B
master ExecuteAsync net472 2.55μs 0.805ns 3.01ns 0.14 0 0 915 B
#7319 ExecuteAsync net6.0 1.85μs 3.4ns 13.2ns 0 0 0 952 B
#7319 ExecuteAsync netcoreapp3.1 2.47μs 4.56ns 17.7ns 0 0 0 952 B
#7319 ExecuteAsync net472 2.6μs 2.2ns 8.52ns 0.143 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 6.96μs 3.99ns 14.9ns 0 0 0 2.36 KB
master SendAsync netcoreapp3.1 8.34μs 13.2ns 51.3ns 0 0 0 2.9 KB
master SendAsync net472 12.2μs 13.1ns 48.9ns 0.489 0 0 3.18 KB
#7319 SendAsync net6.0 6.97μs 10.7ns 40.1ns 0 0 0 2.36 KB
#7319 SendAsync netcoreapp3.1 8.55μs 34.7ns 135ns 0 0 0 2.9 KB
#7319 SendAsync net472 12.2μs 10.7ns 41.4ns 0.486 0 0 3.18 KB
Benchmarks.Trace.Iast.StringAspectsBenchmark - Slower ⚠️ More allocations ⚠️

Slower ⚠️ in #7319

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 1.248 46,100.00 57,550.00 bimodal
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 1.144 476,000.00 544,500.00

More allocations ⚠️ in #7319

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1 255.1 KB 321.74 KB 66.65 KB 26.13%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0 259.93 KB 277.31 KB 17.38 KB 6.69%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑netcoreapp3.1 42.75 KB 45.5 KB 2.75 KB 6.44%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net472 278.53 KB 286.72 KB 8.19 KB 2.94%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net6.0 43.82 KB 44.11 KB 296 B 0.68%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StringConcatBenchmark net6.0 44.3μs 257ns 1.84μs 0 0 0 43.82 KB
master StringConcatBenchmark netcoreapp3.1 46.4μs 253ns 1.32μs 0 0 0 42.75 KB
master StringConcatBenchmark net472 57.7μs 175ns 656ns 0 0 0 65.54 KB
master StringConcatAspectBenchmark net6.0 478μs 2.29μs 11μs 0 0 0 259.93 KB
master StringConcatAspectBenchmark netcoreapp3.1 499μs 2.08μs 7.77μs 0 0 0 255.1 KB
master StringConcatAspectBenchmark net472 409μs 2.28μs 15.3μs 0 0 0 278.53 KB
#7319 StringConcatBenchmark net6.0 48.9μs 663ns 6.59μs 0 0 0 44.11 KB
#7319 StringConcatBenchmark netcoreapp3.1 57.9μs 792ns 7.88μs 0 0 0 45.5 KB
#7319 StringConcatBenchmark net472 56.6μs 279ns 1.15μs 0 0 0 65.54 KB
#7319 StringConcatAspectBenchmark net6.0 547μs 2.16μs 8.66μs 0 0 0 277.31 KB
#7319 StringConcatAspectBenchmark netcoreapp3.1 494μs 6.36μs 63μs 0 0 0 321.74 KB
#7319 StringConcatAspectBenchmark net472 407μs 2.16μs 12μs 0 0 0 286.72 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.59μs 1.66ns 6.22ns 0 0 0 1.7 KB
master EnrichedLog netcoreapp3.1 3.43μs 3.5ns 13.6ns 0 0 0 1.7 KB
master EnrichedLog net472 3.84μs 4.04ns 15.7ns 0.25 0 0 1.64 KB
#7319 EnrichedLog net6.0 2.55μs 12.3ns 47.6ns 0 0 0 1.7 KB
#7319 EnrichedLog netcoreapp3.1 3.45μs 18.4ns 93.9ns 0 0 0 1.7 KB
#7319 EnrichedLog net472 3.95μs 3.84ns 14.9ns 0.255 0 0 1.64 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 123μs 96ns 359ns 0 0 0 4.31 KB
master EnrichedLog netcoreapp3.1 125μs 48.3ns 167ns 0 0 0 4.31 KB
master EnrichedLog net472 166μs 41.4ns 155ns 0 0 0 4.51 KB
#7319 EnrichedLog net6.0 123μs 185ns 692ns 0 0 0 4.31 KB
#7319 EnrichedLog netcoreapp3.1 126μs 47.3ns 170ns 0 0 0 4.31 KB
#7319 EnrichedLog net472 165μs 56.9ns 220ns 0 0 0 4.51 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.94μs 25.3ns 107ns 0 0 0 2.26 KB
master EnrichedLog netcoreapp3.1 6.49μs 22.4ns 86.8ns 0 0 0 2.26 KB
master EnrichedLog net472 7.76μs 5.35ns 20.7ns 0.309 0 0 2.08 KB
#7319 EnrichedLog net6.0 4.86μs 23ns 91.9ns 0 0 0 2.26 KB
#7319 EnrichedLog netcoreapp3.1 6.65μs 7.18ns 27.8ns 0 0 0 2.26 KB
#7319 EnrichedLog net472 7.31μs 5.2ns 20.1ns 0.327 0 0 2.08 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.95μs 9.12ns 35.3ns 0 0 0 1.2 KB
master SendReceive netcoreapp3.1 2.49μs 8.09ns 31.3ns 0 0 0 1.2 KB
master SendReceive net472 3.2μs 2.42ns 9.36ns 0.175 0 0 1.2 KB
#7319 SendReceive net6.0 2μs 9.39ns 36.4ns 0 0 0 1.2 KB
#7319 SendReceive netcoreapp3.1 2.57μs 10.2ns 39.4ns 0 0 0 1.2 KB
#7319 SendReceive net472 3.11μs 3.95ns 15.3ns 0.186 0 0 1.2 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 4.22μs 4.9ns 19ns 0 0 0 1.58 KB
master EnrichedLog netcoreapp3.1 5.58μs 23.1ns 89.5ns 0 0 0 1.63 KB
master EnrichedLog net472 6.55μs 9.11ns 35.3ns 0.295 0 0 2.03 KB
#7319 EnrichedLog net6.0 4.16μs 17.3ns 66.9ns 0 0 0 1.58 KB
#7319 EnrichedLog netcoreapp3.1 5.59μs 8.81ns 34.1ns 0 0 0 1.63 KB
#7319 EnrichedLog net472 6.45μs 5.67ns 22ns 0.29 0 0 2.03 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 748ns 3.85ns 18.4ns 0 0 0 576 B
master StartFinishSpan netcoreapp3.1 945ns 0.736ns 2.85ns 0 0 0 576 B
master StartFinishSpan net472 893ns 0.2ns 0.747ns 0.0895 0 0 578 B
master StartFinishScope net6.0 882ns 0.296ns 1.15ns 0 0 0 696 B
master StartFinishScope netcoreapp3.1 1.22μs 4.97ns 19.3ns 0 0 0 696 B
master StartFinishScope net472 1.13μs 0.155ns 0.599ns 0.102 0 0 658 B
#7319 StartFinishSpan net6.0 744ns 3.97ns 16.8ns 0 0 0 576 B
#7319 StartFinishSpan netcoreapp3.1 947ns 4.7ns 21.5ns 0 0 0 576 B
#7319 StartFinishSpan net472 923ns 0.557ns 2.16ns 0.0879 0 0 578 B
#7319 StartFinishScope net6.0 936ns 0.414ns 1.55ns 0 0 0 696 B
#7319 StartFinishScope netcoreapp3.1 1.18μs 1.67ns 6.48ns 0 0 0 696 B
#7319 StartFinishScope net472 1.11μs 0.831ns 3.22ns 0.1 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 1.08μs 2.19ns 8.46ns 0 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 1.36μs 6.46ns 25.8ns 0 0 0 696 B
master RunOnMethodBegin net472 1.39μs 1.63ns 6.11ns 0.105 0 0 658 B
#7319 RunOnMethodBegin net6.0 1.04μs 5.1ns 21ns 0 0 0 696 B
#7319 RunOnMethodBegin netcoreapp3.1 1.35μs 6.89ns 30.8ns 0 0 0 696 B
#7319 RunOnMethodBegin net472 1.43μs 1.56ns 6.03ns 0.101 0 0 658 B

@NachoEchevarria NachoEchevarria changed the title upgrade packages [NOT FOR MERGING] upgrade packages Aug 8, 2025
@NachoEchevarria NachoEchevarria force-pushed the dotnet10/UpdateToPreview branch from 262574a to 225d52d Compare August 8, 2025 15:41
@andrewlock andrewlock force-pushed the dotnet10/UpdateToPreview branch from 7f334ea to a0e0031 Compare August 12, 2025 16:05
bouwkast and others added 17 commits August 13, 2025 16:08
@bouwkast @NachoEchevarria
Target .NET 8.0 for instrumentation tests
aa5b92d 
They end up getting created with whatever
preview .NET 10 version and then end up looking
for that and not finding it when running
within the .NET 8.0 job.

This should force them to build with .NET 8
and then run with .NET 8 (I think)
@bouwkast @NachoEchevarria
Try to make global.json to use .NET 8
be8f901
@bouwkast @NachoEchevarria
Revert "Try to make global.json to use .NET 8"
39b74c0 
This reverts commit c3dd3d3.
@bouwkast @NachoEchevarria
Revert "Target .NET 8.0 for instrumentation tests"
0d25f0f 
This reverts commit d526168.
@bouwkast @NachoEchevarria
Try a different way to get .NET 8 over .NET 10
c152551
@bouwkast @NachoEchevarria
Swap publish to be self contained
1b206a1 
Attempting to fix issue where it can't find
the correct .NET runtime
@NachoEchevarria
GeneratePackageVersions
50123a8
@NachoEchevarria
update pipeline and docker files
3883063
@NachoEchevarria
upgrade packages
c1a4381
@NachoEchevarria
Try <PackageReference Update="SQLitePCLRaw.lib.e_sqlite3" Version="2.…
a7e86c0 
…1.7" />
@NachoEchevarria
Add RuntimeIdentifiers to project
164bae4
@NachoEchevarria
add runtimeIdentifier
614ba0b
@NachoEchevarria
Fix
e6ef08a
@NachoEchevarria
test
ad3cf62
@NachoEchevarria
Fix sqlite error?
0e96ad1
@NachoEchevarria
test
bd63665
@NachoEchevarria
add Microsoft.Data.Sqlite.Core
d09a2df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NachoEchevarria @bouwkast